Don't need to ask an address for each Ethereum tokens from gemini widget

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.

https://brave.com

Mozilla Public License 2.0

17.99k stars 2.36k forks source link

Closed simonhong closed 3 years ago

simonhong commented 3 years ago

We can share one address for all Ethreum tokens because they all return same address for Ethereum tokens. This only increases the load on the server.

srirambv commented 3 years ago

Brave	1.33.94 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision	`76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}`
OS	:ballot_box_with_check: Linux	:ballot_box_with_check: Windows 11 Version Dev (Build 22504.1010)	:ballot_box_with_check: macOS Version 12.0.1 (Build 21A559)

Verified steps from brave/brave-core#10998 Verified all ERC20 Token's address are loaded when ETH address is loaded