Closed MadhaviSeelam closed 1 year ago
I think this may have something to do with the parallel importer and not firing the import-data-status-changed
event that the Settings WebUI expects. cc: @nullhook
The above requires 1.47.155
or higher for 1.47.x
verification 👍
Verification PASSED on
Brave | 1.47.161 Chromium: 109.0.5414.61 (Official Build) beta (64-bit)
-- | --
Revision | 846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS | Windows 10 Version 21H2 (Build 19044.2364)
Your bookmarks and settings are ready
is shown.
Description
Bookmarks were successfully imported via new onboarding pages and via import bookmarks & settings modal. However, the modal doesn't get dismissed
Steps to Reproduce
Microsoft Edge Profile
Actual result:
Bookmarks were added to the bookmarks bar, but the modal is not auto-dismissed.
https://user-images.githubusercontent.com/98358127/208216311-33c5ebb7-ec86-4f57-b878-a6f75542b8ee.mp4
Expected result:
When clicked on
Import
button, success messageYour bookmarks and settings are ready
dialog should be shown.1.46.x (CR108)
Reproduces how often:
Easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
@mkarolin @rebron @brave/qa-team