brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.99k stars 2.35k forks source link

[CR109]: Import bookmarks and settings modal do not get dismissed after importing bookmarks #27425

Closed MadhaviSeelam closed 1 year ago

MadhaviSeelam commented 1 year ago

Description

Bookmarks were successfully imported via new onboarding pages and via import bookmarks & settings modal. However, the modal doesn't get dismissed

Steps to Reproduce

  1. Install 1.48. 61
  2. launch Brave
  3. click hamburger menu>>Bookmarks>>Import bookmarks and settings
  4. select Microsoft Edge Profile
  5. click Import

Actual result:

Bookmarks were added to the bookmarks bar, but the modal is not auto-dismissed.

https://user-images.githubusercontent.com/98358127/208216311-33c5ebb7-ec86-4f57-b878-a6f75542b8ee.mp4

Expected result:

When clicked on Import button, success message Your bookmarks and settings are ready dialog should be shown.

1.46.x (CR108)

image

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.48.61 Chromium: 109.0.5414.46 (Official Build) nightly (64-bit)
Revision 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709}
OS Windows 11 Version 21H2 (Build 22000.1335)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

@mkarolin @rebron @brave/qa-team
mkarolin commented 1 year ago

I think this may have something to do with the parallel importer and not firing the import-data-status-changed event that the Settings WebUI expects. cc: @nullhook

kjozwiak commented 1 year ago

The above requires 1.47.155 or higher for 1.47.x verification 👍

GeetaSarvadnya commented 1 year ago

Verification PASSED on

Brave | 1.47.161 Chromium: 109.0.5414.61 (Official Build) beta (64-bit)
-- | --
Revision | 846c6eff1c374cde417a9cdc44193545cc07f354-refs/branch-heads/5414@{#1030}
OS | Windows 10 Version 21H2 (Build 19044.2364)