brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.21k stars 2.23k forks source link

PWA icons wrong under KDE (unless icon theme is Breeze) - X11 #33076

Open tejasraman opened 10 months ago

tejasraman commented 10 months ago

Description

If I create a new PWA in KDE, the icon is the same as that of the Brave browser. This does not affect Google Chrome, Edge, or Ungoogled Chromium.

Steps to Reproduce

  1. Install a PWA (e.g Google messages)
  2. Set the icon theme on a KDE distro to something other than Breeze
  3. See the issue

Actual result:

2023-09-17_13-48

Expected result:

PWA uses Messages for web (or other appropriate icon).

Reproduces how often:

Always, unless PWA has predefined icon that's in the package (e.g WhatsApp, Boxy SVG)

Brave version (brave://version info)

1.58.127 Chromium: 117.0.5938.88 (Official Build) (64-bit)

Version/Channel Information:

Stable channel

Other Additional Information:

Miscellaneous Information:

KDE 5.27.8 on Fedora 38 (KDE)

saaivignesh20 commented 9 months ago

I can confirm that I can also reproduce this. Running on KDE Neon 5.27.

But not sure whether this issue is related to Plasma or the browser itself since the same issue can be reproduced with other chromium-based browsers as well.

emailstorbala commented 9 months ago

I am also facing the same issue for Chromium PWA applications like Microsoft 365, Microsoft outlook and Microsoft teams.

Setup:

Operating System: Debian GNU/Linux trixie/sid Kernel: Linux 6.5.0-3-amd64 KDE Plasma Version : 5.27.8 KDE Frameworks Version: 5.107.0 Qt Version: 5.15.10 Graphics Platform: X11

tejasraman commented 8 months ago

I can confirm that I can also reproduce this. Running on KDE Neon 5.27.

But not sure whether this issue is related to Plasma or the browser itself since the same issue can be reproduced with other chromium-based browsers as well.

That's the thing: it's not reproducible anywhere else foe me (Chrome, Edge, vanilla Chromium)

thecyberd3m0n commented 6 months ago

same issue for me, but I'm using Wayland. After changing look&feel back to Breeze PWA icons were applied correctly. The issue is reproduced on Google Chrome, KDE 5.27.8

samrocksc commented 3 weeks ago

Switching to breeze solved this issue for me. I was using WhiteSur-Dark

Operating System: Kubuntu 24.04
KDE Plasma Version: 5.27.11
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.13
Kernel Version: 6.8.0-36-generic (64-bit)
Graphics Platform: X11
Processors: 16 × 13th Gen Intel® Core™ i7-1360P
Memory: 31,1 GiB of RAM
Graphics Processor: Mesa Intel® Graphics
Manufacturer: Framework
Product Name: Laptop (13th Gen Intel Core)
System Version: A6
tejasraman commented 3 weeks ago

Switching to breeze solved this issue for me. I was using WhiteSur-Dark

Operating System: Kubuntu 24.04
KDE Plasma Version: 5.27.11
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.13
Kernel Version: 6.8.0-36-generic (64-bit)
Graphics Platform: X11
Processors: 16 × 13th Gen Intel® Core™ i7-1360P
Memory: 31,1 GiB of RAM
Graphics Processor: Mesa Intel® Graphics
Manufacturer: Framework
Product Name: Laptop (13th Gen Intel Core)
System Version: A6

I haven't really seen the issue with Breeze but I switched to GNOME after the Plasma 6 upgrade so I'm no longer on KDE.