A few minor issues with the address bar since the last few updates

TheJanox824 commented 2 months ago

Description

There's no separation line between the Brave text, and the URL. Also, when the window is maximised, the mouse pointer changes to the resize one (it does nothing) when going to the window border in the address bar.

While these are very minor issues, I'd like to point them out.

Steps to reproduce

For the first issue:

Go to brave://settings, or any other internal Brave site.
See the separator is missing.

For the second:

Maximise the browser and move the cursor to the window border in the address bar.

Actual result

For the first one: brave_addressbarline See there's no separation line.

For the second issue: brave_leftcorner brave_rightcorner I couldn't capture the mouse cursor with Snipping Tool, but it's there.

Expected result

For the first one, this is what it should look like: edge_addressbarline

As for the second issue, it simply shouldn't use the resize pointer.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.68.128 Chromium: 127.0.6533.73 (Official Build) (64-bit)

Channel information

[X] release (stable)
[X] beta
[X] nightly

Reproducibility

[X] with Brave Shields disabled
[X] with Brave Rewards disabled
[ ] in the latest version of Chrome

Miscellaneous information

I know it happens on Windows 10 and 11. Don't know about other platforms. None of these issues were there before the address bar and tabs were redesigned earlier this year.

rebron commented 2 months ago

cc: @aguscruiz

ajayseeker commented 1 month ago

Hi @TheJanox824 and @rebron, Can you please assign me this issue? I'd like to work on it.

ajayseeker commented 1 month ago

Hi @fallaciousreasoning @aguscruiz @rebron and @TheJanox824 I need some clarification. Do we need the separator only for Brave Internal Websites?

or, do we need this as a generic change independent of sites?

aguscruiz commented 1 month ago

Seems like the divider only appears on internals, but I can't tell for sure. Maybe others can confirm

TheJanox824 commented 1 month ago

Hi. On Edge (which I used for the comparison in the original post), it only appears on internals. I don't know how it is on Chrome, or how you want it to be on Brave. I just noticed the separator was missing and thought it was a bug, since it was there before Brave's redesign.

aguscruiz commented 1 month ago

Ok, thanks! Yeah @ajayseeker let's keep it for internals only then. The color token the divider should use is --leo-color-divider-subtle.

Also, small thing the divider should be 16px tall and centered vertically.

Should look like this:

Thanks! :D

brave / brave-browser