search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.94k stars 2.35k forks source link

Fix BraveRoundTimeStamps conflict with ReCaptcha #41472

Open atuchin-m opened 1 month ago

atuchin-m commented 1 month ago

BraveRoundTimeStamps results in OOMs on sites that use ReCaptcha. The details and steps to reproduce is here: https://github.com/brave/brave-browser/issues/40886

The feature will be disabled soon to fix the issue. If we want to re-enable it, we should find a way to resolve the conflict.

bsclifton commented 1 month ago

This change definitely affected YouTube too. See https://github.com/brave/brave-browser/issues/29432#issuecomment-2415096531

@szilardszaloki had attempted a fix with https://github.com/brave/adblock-resources/pull/131... and some users reported that worked. But it definitely broke again.

After the revert via variations server, multiple folks confirmed YouTube history is now working great for them

If there is a proposed fix for this in the future, we'll want to run through the test plan in https://github.com/brave/brave-browser/issues/29432 to make sure it works for that case too.

atuchin-m commented 1 month ago

Sounds great, @bsclifton, thanks for the details!