search

brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
17.93k stars 2.35k forks source link

[Follow up #41782] Pressed state for Leo icon is not shown when tab with Leo panel teared off although the icon is in active state #42010

Open MadhaviSeelam opened 3 weeks ago

MadhaviSeelam commented 3 weeks ago

Description

Found while testing https://github.com/brave/brave-browser/issues/41782. Before tearing off the tab from the window, Leo panel is activated and the icon shows as active and pressed state as expected, but after tearing off the tab, Leo icon shows active (nala blue color) but didn't show pressed state. This issue happens only in Win 11 x64. Verified in macOS arm64 and both active icon and pressed states are shown.

Steps to reproduce

  1. Install 1.72.93
  2. launch Brave
  3. open two tabs
  4. click Leo icon on the sidebar for one of the tabs
  5. detach the tab that has Leo panel activated

Actual result

Leo icon is shown as active, but the pressed state is not restored. Had to hover the icon to show the pressed state

https://github.com/user-attachments/assets/612c0866-33b1-4c27-bbe2-8f3beb4b966a

Expected result

Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.72.93 Chromium: 131.0.6778.14 (Official Build) beta (64-bit)
Revision 69e5dc20ca483a13316632df5bcd9279bb2a3cb7
OS Windows 11 Version 23H2 (Build 22631.4391)

Channel information

Reproducibility

Miscellaneous information

@simonhong @rebron cc: @brave/qa-team

simonhong commented 3 weeks ago

From the recording, item has still activated state but button's highlight color not rendered.