brave / brave-browser

Brave browser for Android, iOS, Linux, macOS, Windows.
https://brave.com
Mozilla Public License 2.0
19.54k stars 2.62k forks source link

Brave "forgot" some passwords and is not saving new passwords #45171

Open Dylan-86 opened 2 months ago

Dylan-86 commented 2 months ago

Description

Starting today with version Version 1.77.95 Chromium: 135.0.7049.52 (Official Build) (64-bit) On Ubuntu 24.04 with KDE Plasma

it seems that Brave forgot some passwords that used to be in the keyring. Some passwords were saved yesterday, others years ago (GitHub's login info, for example), and are no longer there.

On Android I can still see them, instead.

If I save a new password then close the browser, restart it, the new password is not there.

Also, each time I close and reopen Brave, I get logged out from every single website, even with shields down and cookies saved.

Steps to reproduce

  1. Open Brave, add a new login/password
  2. Close brave (and terminate all processes with 'pkill brave' in terminal)
  3. Re-open brave and check if the login info is there

Actual result

The new login info is not there

Expected result

The login info should be there

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.77.95 Chromium: 135.0.7049.52 (Official Build) (64-bit)

Brave 1.77.95 Chromium: 135.0.7049.52 (Official Build) (64-bit) Revision 9e0bf4d8fff1d4549561cf6f59c2a200a0fb516f OS Linux JavaScript V8 13.5.212.10 User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/135.0.0.0 Safari/537.36 Command Line /opt/brave.com/brave/brave --disable-domain-reliability --enable-dom-distiller --enable-distillability-service --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --lso-url=https://no-thanks.invalid --sync-url=https://sync-v2.brave.com/v2 --variations-server-url=https://variations.brave.com/seed --variations-insecure-server-url=https://variations.brave.com/seed --flag-switches-begin --flag-switches-end --component-updater=url-source=https://go-updater.brave.com/extensions Executable Path /opt/brave.com/brave/brave Profile Path /home/ddy/.config/BraveSoftware/Brave-Browser/Default Command-line Variations eyJkaXNhYmxlLWZlYXR1cmVzIjoiQnJhdmVBZGJsb2NrRGVmYXVsdDFwQmxv... Active Variations main@3fabdeee68fbe36e507b486c2b5b1ce695adde21 AllowCertainClientHintsStudy:Enabled BraveAIChatDefaultModelStudy:DefaultLlama BraveAdblockMobileNotificationsListDefault:Enabled BraveAdsAdEventStudy:Enabled BraveAdsConversionsStudy:Enabled BraveAdsExclusionRulesStudy:Enabled BraveAdsNewTabPageAdsStudy:Enabled BraveAdsSiteVisitStudy:Enabled BraveAdsTextClassificationPageProbabilitiesStudy:Enabled BraveAggressiveModeRetirementExperiment:Disabled BraveAutoTranslateStudy:AutoTranslateDisabled BraveDebounceStudy:Enabled BraveFeedUpdateStudy:Enabled BraveForgetFirstPartyStorage:Enabled BraveGoogleSignInPermissionStudy:Enabled BraveHorizontalTabsUpdateEnabledStudy:Enabled BraveP3AConstellationEnabled:Enabled BraveP3AJSONOtherDeprecation:Enabled BraveP3ANebulaRelease:Enabled BraveP3ATypicalJSONDeprecationEnabled:Enabled BraveRewardsAllowSelfCustodyProvidersStudy:Enabled BraveRewardsNewRewardsUIStudy:Enabled BraveRewardsWebUiPanelStudy:Enabled BraveScreenFingerprintingBlockerStudy:Enabled BraveSearchAdStudy:Enabled BraveSplitViewStudy:Enabled BraveWalletAnkrBalancesEnabled:Default BraveWebcompatExceptionsServiceReleaseStudy:Enabled ClampPlatformVersionClientHint:Disabled CookieListDefaultStudy:Enabled Default1pBlockingStudy:Disabled DisableReduceLanguage:Enabled EphemeralStorageStudy:Enabled ExtensionsManifestV2StudyRelease:Enabled PartitionedCookies:Enabled SeedFileTrial:Default UndecryptablePasswords:Enabled UserActivityStudy:Triggers WhatsNewStudy:Enabled

Channel information

Reproducibility

Miscellaneous information

Dylan-86 commented 2 months ago

I rolled back to 1.75.180 Chromium: 133.0.6943.126 (Official Build) (64-bit)

and everything is back to normal.

Also inside brave://version I don't see anymore the "Active Variations"

Brave 1.75.180 Chromium: 133.0.6943.126 (Official Build) (64-bit) Revision 2d6235ab2377d8b6e71df03a3ce911ab7c5a3255 OS Linux JavaScript V8 13.3.415.22 User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/133.0.0.0 Safari/537.36 Command Line /opt/brave.com/brave/brave --disable-domain-reliability --enable-dom-distiller --enable-distillability-service --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --lso-url=https://no-thanks.invalid --sync-url=https://sync-v2.brave.com/v2 --variations-server-url=https://variations.brave.com/seed --variations-insecure-server-url=https://variations.brave.com/seed --flag-switches-begin --flag-switches-end --component-updater=url-source=https://go-updater.brave.com/extensions Executable Path /opt/brave.com/brave/brave Profile Path /home/ddy/.config/BraveSoftware/Brave-Browser/Default Command-line Variations eyJkaXNhYmxlLWZlYXR1cmVzIjoiIiwiZW5hYmxlLWZlYXR1cmVzIjoiIiwi...

LegendEronZ commented 2 months ago

Experienced the same on Arch KDE, rolled back to 1.76.82 and its fine.

Please let me know if you need any info to fix this and I will try again.

wknapik commented 2 months ago

cc @fmarier @kjozwiak @rebron

ahf85br commented 2 months ago

Same issue here for the same version. Very annoying that is not saving login cookies. I have to login on all websites again after closing brave.

Sarania commented 2 months ago

Experienced the same on Arch KDE, rolled back to 1.76.82 and its fine.

Please let me know if you need any info to fix this and I will try again.

Can confirm this issue and this temporary fix. Endeavour/Arch running linux 6.14.0, KDE6 on Wayland. I can also provide any other info needed.

P.S. If you installed from the AUR and use a helper, you likely have a working version cached you can install such as for yay:

pacman -U .cache/yay/brave-bin/brave-bin-1\:1.76.82-1-x86_64.pkg.tar.zst
rajkhare05 commented 2 months ago

Add --disable-features=UseFreedesktopSecretKeyProvider flag while launching brave. brave-browser: #44803 Chromium: #6431417

fmarier commented 2 months ago

You could also try specifying kwallet6 explicitly on the command line using --password-store=kwallet6.

Sarania commented 2 months ago

It's also fixed for me in nightlies (specifically Nightly v1.79.42 (Chromium 135.0.7049.52)) after: https://github.com/brave/brave-browser/issues/45248 https://github.com/brave/brave-variations/pull/1356