Can't disable crypto wallets

wooque commented 4 years ago

Description

There is no setting anymore to disable crypto wallets

Steps to Reproduce

Open chrome://settings/ -> Extensions
No setting to disable crypto wallets

Actual result:

There is no setting to disable crypto wallets

Expected result:

There is setting to disable crypto wallets

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.5.112 Chromium: 80.0.3987.132 (Official Build) unknown (64-bit) Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974} OS Linux JavaScript V8 8.0.426.26 Flash (Disabled) User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.132 Safari/537.36 Command Line /usr/lib/brave-bin/brave --enable-features=OverlayScrollbar --disable-features=TabHoverCards --disable-smooth-scrolling --enable-gpu-rasterization --ignore-gpu-blacklist --enable-dom-distiller --disable-domain-reliability --no-pings --extension-content-verification=enforce_strict --extensions-install-verification=enforce --sync-url=https://no-thanks.invalid --enable-features=PasswordImport,SimplifyHttpsIndicator,WebUIDarkMode,OverlayScrollbar --disable-features=AllowPopupsDuringPageUnload,LookalikeUrlNavigationSuggestionsUI,NotificationTriggers,AutofillServerCommunication,AudioServiceOutOfProcess,TabHoverCards,SmsReceiver,VideoPlaybackQuality,WebXrGamepadModule,WebXR --flag-switches-begin --flag-switches-end --disable-webrtc-apm-in-audio-service --disable-sync Executable Path /usr/lib/brave-bin/brave Profile Path /home/vuk/.config/BraveSoftware/Brave-Browser/Default

Version/Channel Information:

Can you reproduce this issue with the current release? Yes
Can you reproduce this issue with the beta channel? /
Can you reproduce this issue with the dev channel? /
Can you reproduce this issue with the nightly channel? /

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? /
Does the issue resolve itself when disabling Brave Rewards? /
Is the issue reproducible on the latest version of Chrome? /

Miscellaneous Information:

eljuno commented 4 years ago

+1 from Community https://community.brave.com/t/disable-brave-wallet/116840/4?u=eljuno

rohitghali commented 4 years ago

+1 from me.

RJVB commented 4 years ago

+1

I noticed it popping up in the task manager, with a few percents of CPU usage. Not consistently but enough to send me on a search that made me land here.

The IPFS extension is downloaded on demand, why not do the same with this one (and any other extension that most users will probably never have use for)?

Rhevin commented 4 years ago

+1 from me

juanmcortez commented 4 years ago

+1 from me too ...

dandai commented 4 years ago

+1

say4n commented 4 years ago

+1

Taomyn commented 4 years ago

+1

calebbarr commented 4 years ago

+1

thylux commented 4 years ago

+1

Deses commented 4 years ago

Extension Crypto Wallets is using about 70 MB of RAM and I wish for it to be gone. I have plenty of ram but I just don't want this crap installed.

I switched from Chrome to avoid this kind of BS, and this is pretty disappointing.

Also, wtf is this? If it's crypto related I just want it gone.

RJVB commented 4 years ago

On Friday May 29 2020 19:10:13 Carlos R wrote:

Also, wtf is this?

I've been wondering about those too. They bring back not-fond old memories of something called "The Bat" in relation to spam, so seeing "Bat Ads Service" isn't very nice.

Deses commented 4 years ago

On Friday May 29 2020 19:10:13 Carlos R wrote: Also, wtf is this? I've been wondering about those too. They bring back not-fond old memories of something called "The Bat" in relation to spam, so seeing "Bat Ads Service" isn't very nice.

Nothing to do with spam. BAT is their Basic Attention Token, Brave's crypto to pay creators because we block ads.

I can't even enable the thing in my country! Let me get rid of this.

nightcometh commented 4 years ago

+1 from me as well, this a very big negative

part of the reason people switched to brave is to avoid these type of background resources that are always on without the user's permission, sucking resources and sending data to ???

back to seamonkey until this is resolved

joshxyzhimself commented 4 years ago

https://news.ycombinator.com/item?id=23442027

Deses commented 4 years ago

https://news.ycombinator.com/item?id=23442027

Thanks for that link. I guess I'm better off going back to Chrome.

micnguyen commented 4 years ago

Thanks for that link. I'm also deleting Brave and going back to Chrome. This GH Issue along with that link shows to me unfortunately that the developers are not only sneaking in stuff but blatantly lying about it. Sorry guys, it was a good 3 months run with the browser.

codybrom commented 4 years ago

+1. Don't waste my RAM for features I've disabled.

bbondy commented 4 years ago

Just an FYI that this is now lazy loaded with 1.10.x (which will be released either today or Monday), so it will only load Crypto Wallets if you navigate to brave://wallet.

A further change also makes it so you need to explicitly opt-in and without that it will never start it at all.

Keeping this open since there's still no option to disable it after you explicitly opt-in though. But it will be already off for most users as of 1.10.x.

Invisible40 commented 4 years ago

Can I turn off the "Set up Crypto Wallets" banner that appears on some websites?

marcbousaleh commented 4 years ago

Can I turn off the "Set up Crypto Wallets" banner that appears on some websites?

That's exactly what I'm looking for, it is really annoying. Please notify me if you found a way to disable it.

bbondy commented 4 years ago

Yes you can set Web3 provider for using Dapps setting to None in brave://settings/extensions or you can just keep it on Brave Wallet but turn on Load Crypto Wallets on startup

xlcrr commented 4 years ago

Settings - Extensions - First item ( Web3 provider for Dapps) - None

Should be default. Really annoying

AJolly commented 4 years ago

I'd like to fully disable it, it keeps interfering with nifty or metamask.

bbondy commented 4 years ago

@AJolly see 2 messages up, you can set it to MetaMask.

Rishirandhawa commented 4 years ago

Brave wallet is making Metamak unusable... there has to be a feature to fully disable/remove Brave wallet. Surprised that this is not a top priority. I think Brave is the best browser but will sadly have to be deleted

bbondy commented 4 years ago

@Rishirandhawa I think you just want to set this setting to MetaMask:

There's code in Beta now by the way going to Release in 3 weeks that will auto set that to MetaMask for new installs instead of prompting.

RJVB commented 4 years ago

I think Brave is the best browser but will sadly have to be deleted

Have you tried Slimjet? It too has a builtin ad blocker, and it's quite fast.

Rishirandhawa commented 4 years ago

I haven't.. will give it. try. Thanks

guttermonk commented 4 years ago

The Crypto Wallets extension (that can't be disabled in v1.15) is keeping my Ledger hardware wallet from connecting to MetaMask. Ledger and MetaMask work fine in other browsers.

Even after setting "Load Crypto Wallets on startup" to OFF and setting the "Web3 provider for using Dapps" to MetaMask, I still can't connect my Ledger to MetaMask. There's no way to disable the Crypto Wallet extension that no one wants/supports... For that, I'm out.

Rishirandhawa commented 4 years ago

@guttermonk I have exactly the same setup and problem. It renders it completely unusable.

guttermonk commented 4 years ago

Tried uninstalling MetaMask, clearing my cache, rebooting, connecting my Ledger, starting Brave, opened Crypto Wallets, and tried to "Connect Hardware Wallet" ...still getting the eternal spinner of death.

ghost commented 4 years ago

+1

tomgo5k commented 3 years ago

+1

xanoni commented 3 years ago

As a workaround, I've disabled it under "Extensions" (brave://extensions/).

Does anyone know what the benefit of the Brave wallet is over Metamask? I gave the Brave wallet a shot, but it complained about Trezor Connect being incompatibly versioned, so I just went back to Metamask. Thank you.

Taomyn commented 3 years ago

@M09NST3R how do you get the extension to appear because it's not listed as one in my extension manager?

srirambv commented 3 years ago

@Taomyn can you check what version you have from brave://components ?

Taomyn commented 3 years ago

@srirambv not there either

srirambv commented 3 years ago

@Taomyn you need to have the CW page open and then check. The component only loads when you have CW page open

Taomyn commented 3 years ago

@Taomyn you need to have the CW page open and then check. The component only loads when you have CW page open

Ok, so maybe if I do not go beyond this when I go into Settings and click on "Crypto Wallets" then I will not have it anyway?

srirambv commented 3 years ago

@Taomyn I don't think you have CW installed so not sure why you want it to be removed? If you are looking to disable/remove UI elements for CW that is not possible. You can only remove/uninstall the extension if its installed. Please see @bbondy's message above

bbondy commented 3 years ago

You'll be able to set the new Default wallet to none with this https://github.com/brave/brave-browser/issues/18213

MommysLilPogChamp commented 3 years ago

+1

bbondy commented 3 years ago

You can do this via brave://settings/wallet by setting Default cryptocurrency wallet to None and changing Show Brave Wallet icon on toolbar to off.

brave / brave-browser