brave / brave-ios

Brave iOS Browser
https://brave.com
Mozilla Public License 2.0
1.68k stars 440 forks source link

Accounts tab added accounts race condition #8750

Closed StephenHeaps closed 4 months ago

StephenHeaps commented 4 months ago

Description:

When an account is added while balances are fetched on Accounts tab, it might be temporarily missing after balances are fetched, or accounts tab is re-opened.

Steps to Reproduce

  1. I used network link conditioner to slow network on device
  2. Open Accounts tab
  3. Tap ... -> Add Account
  4. Add a new account (before balances fetched)
  5. Add account modal dismisses, then wait for balance load
  6. Observe the new account might be missing (race condition)

Actual result:

https://github.com/brave/brave-ios/assets/5314553/606e0a0f-44a8-4a86-af47-ab037a1e24b7

Expected result:

All accounts should be visible at all times on Accounts tab

Reproduces how often:

Easily reproduced (with network link conditioner)

Brave Version:

Device details:

Website problems only:

Additional Information