brave / browser-laptop

[DEPRECATED] Please see https://github.com/brave/brave-browser for the current version of Brave
https://www.brave.com
Other
7.95k stars 977 forks source link

Make brave unusable to encourage updating #15346

Closed diracdeltas closed 5 years ago

diracdeltas commented 5 years ago

This PR replaces the newtab page with the notice to update Brave and makes the urlbar unusable.

Test plan:

  1. Launch Brave without brave-core installed
  2. You should see a notice to update brave.
  3. Clicking on it should download Brave.
  4. The urlbar should not be usable.
  5. With brave-core now installed, launch the old Brave again.
  6. Now you should see a notice to launch the newer Brave installation.
  7. The urlbar should still be unusable.

Test plan for disabling tab restoration:

  1. Open previous version of muon brave and open some tabs/windows
  2. Update to this version
  3. You should not see any of your tabs/windows restored

Screenshot:

Screen Shot 2019-03-28 at 4 23 38 PM

Submitter Checklist:

Test Plan:

Reviewer Checklist:

Tests

diracdeltas commented 5 years ago

just realized, i should disable tab restoration too

diracdeltas commented 5 years ago

tab restoration disabling is done now

bsclifton commented 5 years ago

@diracdeltas you can still open private/Tor tabs, which don't show our new messaging

Should we disable these too?

diracdeltas commented 5 years ago

you can still open private/Tor tabs, which don't show our new messaging

good catch, will disable private tabs

diracdeltas commented 5 years ago

@bsclifton changed it so that private/tor tabs now also show the notice