Closed ishanspatel closed 8 years ago
I've had this too :frowning: I haven't been able to find a way to get it working, but I can offer this work-around:
"pre-commit": "brave/pre-commit",
npm install
This will let the npm install finish and running the app will work. Besides the pre-commit hooks not firing, the only issue is that you can't commit without deleting the pre-commit hook file (it'll complain on commit). Once you delete that, you're good to go. This has been an issue for a while
I did notice if you try to install the regular pre-commit package (instead of the brave/pre-commit version), the install does seem to work. I didn't test running the app afterwards though
Thanks @bsclifton :+1:. Finally, it's working in windows 10.
I think it's worthwhile to keep this open- it would be nice to not have to use a work-around to get npm dependencies installed
Fixed w/ https://github.com/brave/browser-laptop/commit/0e6fb341cca06deb5e3d8f42cea384515a942ea9
Thanks, @bbondy :smile:
Describe the issue you encountered: I have followed steps mentioned in wiki "Troubleshooting" Replaced git.js as mentioned in the same wiki Installed everything as mentioned in the said wiki
node -v: 6.2.0 npm -v: 3.8.9 node-gyp -v: 3.2.1 OS: Windows 10 x64 Now, I've done git cloning of browser-laptop repo Then npm install And then getting this error
Then I followed these commands:
Both executed successfully
Then I followed these commands in new power shell window:
npm run
successfully executednpm start
executed with errors as shown bellowKindly help me with solution of this. Trying these with past 7-8 days, but didn't got any success in windows 10. Thanks in advance!