search

braze-inc / braze-xamarin-sdk

Xamarin bindings for the Braze Android and iOS SDKs
https://www.braze.com
Other
3 stars 8 forks source link

This is a proposed fix for casting issue of Appboy.SharedInstance?.InAppMessageController.InAppMessageUIController #8

Closed wayousuf closed 10 months ago

wayousuf commented 3 years ago

…ppboy.SharedInstance.InAppMessageController.InAppMessageUIController, what I figured out that there are two implementations of IABKInAppMessageUIControlling interface, ABKInAppMessageUIControlling and ABKInAppMessageUIController, even though in InAppMessageController property type InAppMessageUIController is ABKInAppMessageUIControlling but at the native side it's being still using the ABKInAppMessageUIController, that's the reason to getting the casting issue, just updated the InAppMessageUIController property type to ABKInAppMessageUIController and issue has been resolved.

radixdev commented 3 years ago

Hi @wayousuf ,

Thanks for the pull request. This code looks correct to us and we'll be incorporating it into our private repository. We'll update you once that's done.

hokstuff commented 10 months ago

Hello,

I am closing out this public PR due to inactivity and staleness. If you have further questions, feel free to contact support@braze.com.

Thanks!