search

breach / mod_strip

Breach default layout / tabbing module
38 stars 40 forks source link

Strip disappears when an image is dragged onto the strip #32

Closed dvdchr closed 10 years ago

dvdchr commented 10 years ago

Please look at the screenshot below: mod_strip_image_bug

Explanation Notice that above the Google logo, there's a Wikipedia logo. It is actually a new frame / viewport, created on top of the existing mod_strip/tabs region because I dragged an image there. I can still switch tabs with the ctrl + tab key.

Repro steps Drag an image to the mod_strip region.

Expected behavior A new tab is created, containing the image source URL.

spolu commented 10 years ago

That's an interesting bug! :) So I guess the default behaviour of the webview is to open the image... I wonder if we can disable that behaviour from the client code...

t-lutz commented 10 years ago

The submitted PR disables drop event alltogether. Dropping might be doing more clever things like loading the content in a new tab for example, but this PR is a bugfix, not a feature enhancement ;)

I think it might be a core problem: changing the content of a control panel should never be triggered in any way other than programatically.

spolu commented 10 years ago

This has been published in v0.2.12!