search

breach / mod_strip

Breach default layout / tabbing module
38 stars 40 forks source link

Search bar wipes search term on focus lost #53

Closed JamoBox closed 2 years ago

JamoBox commented 10 years ago

There is a minor bug when typing a search in the URL bar, if the window loses focus the search term is wiped and set back to an empty box if on a blank page, or if on a page the page's URL. The search term should persist until the user either cancels it by clicking elsewhere on the page or hitting escape. This is mainly down to intuitiveness, so perhaps it's not so much as a bug but a feature request.

spolu commented 10 years ago

Thanks! Marked as bug. PRs welcome! :)

jonathan-reisdorf commented 10 years ago

see this PR: https://github.com/breach/mod_strip/pull/66

behavior is now more like in other browsers, also clicking on the document will not erase search term unless it was empty. but I have one more question: should it be erased on tab change? if so, what could be the best practise to achieve that? box and strip are different components and just getting the status change is not information enough to detect that the user has clicked on a different tab afaik