search

breez / breez-sdk-greenlight

MIT License
244 stars 43 forks source link

fix flutter pubspec for CI #1066

Closed JssDWt closed 3 months ago

JssDWt commented 3 months ago

CI was failing due to a pubspec.lock change coming from an upgrade to flutter 3.24.0. Example: https://github.com/breez/breez-sdk-greenlight/actions/runs/10301350088/job/28512698340?pr=1065

erdemyerebasmaz commented 3 months ago

@JssDWt Let's hold off with these changes for a day.

Flutter 3.24 has introduced a regression on building apps for release on Android and we might want to stick to Flutter 3.22.3 as a workaround until further notice.

Created an issue:

I am actively looking for a fix on 3.24.

JssDWt commented 3 months ago

@JssDWt Let's hold off with these changes for a day.

We could also pick a specific flutter version in the SDK CI for the time being?

erdemyerebasmaz commented 3 months ago

@JssDWt Let's hold off with these changes for a day.

We could also pick a specific flutter version in the SDK CI for the time being?

Yes, let's pin Flutter version to 3.22.3 for the time being.

This can be achieved by specifying flutter-version on Flutter setup steps. 

      - uses: subosito/flutter-action@v2
        with:
          channel: 'stable'
          flutter-version: 3.22.3
JssDWt commented 3 months ago

Yes, let's pin Flutter version to 3.22.3 for the time being.

will do.

84ce07cd7b839df1ddd2da6c2db88fa7cbc739ad already added the pubspec changes, so we're just a commit too late, dang.

I'll fix that pubspec back too.

JssDWt commented 3 months ago

Closing in favor of https://github.com/breez/breez-sdk-greenlight/pull/1069