search

breez / breez-sdk-greenlight

MIT License
244 stars 43 forks source link

Parse web URLs with `lightning` query param #986

Closed andrei-21 closed 6 months ago

ok300 commented 6 months ago

What is the use-case for such URLs?

When specified as a URL, we risk not getting part of it, because AFAIK different browsers and clients have a max length for an URL with GET params.

Isn't a more standard-conform way doing it with the lightning: URI prefix, which the SDK already handles?

roeierez commented 6 months ago

@ok300 it is part of the standard to pass lnurl as part of other uri schemes: https://github.com/lnurl/luds/blob/luds/01.md

We do support it in breezmobile and Idont see why not to support it.

roeierez commented 6 months ago

We don't control the way lnurl is encoded as some wallets use the fallback scheme like this.

andrei-21 commented 6 months ago

I find it weird as well, but the market things differently: Lnbits puts such urls into qr codes, https://tipcards.io does a similar thing.

On May 24, 2024 1:02:43 PM GMT+01:00, ok300 @.***> wrote:

What is the use-case for such URLs?

When specified as a URL, we risk not getting part of it, because AFAIK different browsers and clients have a max length for an URL with GET params.

Isn't a more standard-conform way doing it with the lightning: URI prefix, which the SDK already handles?

-- Reply to this email directly or view it on GitHub: https://github.com/breez/breez-sdk/pull/986#issuecomment-2129362941 You are receiving this because you authored the thread.

Message ID: @.***>

ok300 commented 6 months ago

@andrei-21 can you please rebase and fix the conflicts?

We can then review and merge.

andrei-21 commented 6 months ago

@ok300 done.