search

brefphp / bref

Serverless PHP on AWS Lambda
https://bref.sh
MIT License
3.12k stars 366 forks source link

close #1369 increase the php-fpm log limit to match AWS Cloudwatch #1824

Closed allan-simon closed 3 months ago

allan-simon commented 3 months ago

So that the php-fpm process will not hang when reaching log_limit (it can still reach but it's muchhh harder, and reaching it would anyway cause an error with AWS Cloudwatch )

mnapoli commented 3 months ago

Hi, this branch is a very old (obsolete) branch:

Screen-001826

You might want to open this against https://github.com/brefphp/aws-lambda-layers

So that the php-fpm process will not hang when reaching log_limit

I'm not sure I understand why the fpm process would hang when reaching log_limit? I understand that the setting will split log lines (bad), but why is anything hanging?

Also have you been able to reproduce the problem and check that this change fixes it?

Thanks!

allan-simon commented 3 months ago

@mnapoli I will reopen in the other repository , I see that in that one there's clear instruction on how to build the layer so i will be able to test if that actually fix the issue, but looking to the php-src issue I'm pretty confident it does, though I agree with you I'm not sure why it hangs (and I can't reproduce it with the -dev layer )

so I will try to build a custom layer with my patch , deploy it in our test environment in aws