brendanhay / gogol

A comprehensive Google Services SDK for Haskell.
Other
280 stars 105 forks source link

Update generated services, remove generated lenses, and various miscellaneous generator fixes #174

Closed brendanhay closed 2 years ago

brendanhay commented 2 years ago

Summary of changes

Moving forward

brendanhay commented 2 years ago

A note on naming of (product) smart constructors and (sum) pattern synonym accessors:

This is mildly unfortunate, probably it would've been better to use mk / un as the prefixes since we'd likely never have to special case anything, but I hope for the day we can just pervasively enable NoFieldSelectors and not deal with this.

brendanhay commented 2 years ago

Closes #169

sternenseemann commented 2 years ago

Can we get a new release to hackage with these changes included. A lot of useful fixes have accumulated on the main branch by now, including ones I believe should allow compiling with the new Stackage LTS 19 snapshots.

tonyalaribe commented 2 years ago

It appears the docs for the new types don't reflect on hackage. It's not clear to me how the fields should be used, since the old lens accessors don't work anymore