search

brentvatne / stargrave-0

preserving my stars for vanity. former home of react-native-modal
389 stars 65 forks source link

ListView in Modals don't work properly in with forceToFront #11

Closed dhrrgn closed 9 years ago

dhrrgn commented 9 years ago

In our Modal we have a <ListView> inside it, with a set height. With forceToFront set to false, the list scrolls correctly. However, when we set forceToFront to true, the list no longer scrolls.

Internally, a ListView is implemented as a ScrollView containing Views, so I suspect the issue is actually with the ScrollView.

brentvatne commented 9 years ago

@dhrrgn - interesting, I hadn't tried combining these yet, if you have a chance to try to debug it that would be great, otherwise I can probably look at it this weekend :smile:

dhrrgn commented 9 years ago

@brentvatne Sorry, I did not have a chance to look at it yet. I will take a look tomorrow though and see what I can come up with. I am not sure whether the bug is in Modal or Overlay, so this issue may be in the wrong project.

brentvatne commented 9 years ago

@dhrrgn - No problem. I think the issue is probably with Overlay, take your time as it looks like nobody else has run into this issue yet. Thanks a lot!

dhrrgn commented 9 years ago

@brentvatne I took a look and couldn't figure it out. However, I can be fairly certain the issue in the Obj-C side of things, as I have tried everything I thing I can think of in the Overlay.ios.js stuff. I suspect it has something to do with the way the subviews are put into the new UIWindow? Maybe?

brentvatne commented 9 years ago

@dhrrgn - seems likely, I'll add it to a list of things to look at this weekend, thanks for checking it out!

brentvatne commented 9 years ago

@dhrrgn - yeah this is a tricky one, couldn't figure it out :( It looks like the height of the ScrollView isn't properly being set - notice that with forceToFront as true there is no scrollbar

rxb commented 9 years ago

Not sure if this is a useful data point, but it looks like it also happens just when using the Overlay on its own.

brentvatne commented 9 years ago

@rxb - thanks for the info, I noticed the same thing on my end

Furizaa commented 9 years ago

+1

I would try to help if I could. But sadly I have absolutely no idea what is happening on the iOS side of things.

brentvatne commented 9 years ago

@Furizaa @dhrrgn @rxb - fixed with react-native-overlay 0.2.2, should work with 0.3.5 of this lib :smile:

dhrrgn commented 9 years ago

Awesome. Thanks @brentvate (and @johanneslumpe).

rxb commented 9 years ago

Thanks!