search

brentvatne / stargrave-0

preserving my stars for vanity. former home of react-native-modal
389 stars 65 forks source link

Modal container should have settable pointerEvents #16

Closed premasagar closed 9 years ago

premasagar commented 9 years ago

Hi. Thanks for this module. For my use case, I am overriding styles.modal so that the modal body container is transparent and fills the view: {position:'absolute', left:0, right:0, top:0, bottom:0}. I have buttons inside the container. The problem I have is that I need pointerEvents="box-none" set on the modal body container, so that touch events pass through, to allow a backdropPress to close the modal.

The renderBody() method could use this.props.modalPointerEvents or maybe better, check for a flag like this.props.hideModalContainer.

brentvatne commented 9 years ago

Interesting use case! Care to try your hand at a pull request?

premasagar commented 9 years ago

OK, sure.

premasagar commented 9 years ago

Done: https://github.com/brentvatne/react-native-modal/pull/17 I went with allowing the low-level pointerEvents property itself, as there may be use cases for one value or another.