search

brettlangdon / node-dogapi

Datadog API Node.JS Client
https://brettlangdon.github.io/node-dogapi/
105 stars 45 forks source link

share function in screenboard.js doesn't share the given board #60

Closed mahhafez closed 6 years ago

mahhafez commented 6 years ago

in Screenboard.js the function share is not using the correct http method it should be "POST" instead of "GET" as the current behavior wont actually share the given screen-board function share(boardId, callback){ client.request("GET", util.format("/screen/share/%s", boardId), callback); } it should be function share(boardId, callback){ client.request("POST", util.format("/screen/share/%s", boardId), callback); }

mahhafez commented 6 years ago

I can see the issue should be fixed in https://github.com/brettlangdon/node-dogapi/pull/57

brettlangdon commented 6 years ago

Merged and released #57 under version 2.8.3.