search

brianc / node-pg-cursor

Query cursor extension for node-postgres
79 stars 30 forks source link

Emit Query Events #25

Closed sberan closed 7 years ago

sberan commented 7 years ago

This change adds events to the Cursor object as per the Query API.

See https://github.com/brianc/node-pg-cursor/issues/24 for background and discussion.

brianc commented 7 years ago

Beautiful! Love it! 💃

brianc commented 7 years ago

I'll push a new minor version out now.

brianc commented 7 years ago

hmmm when I run "make test" on this branch I'm getting an error:

error handling
    1) can continue after error

1) error handling can continue after error:
     Uncaught error: syntax error at or near "asdfdffsdf"
      at Connection.parseE (/Users/bmc/src/node-pg-cursor/node_modules/pg/lib/connection.js:551:11)
      at Connection.parseMessage (/Users/bmc/src/node-pg-cursor/node_modules/pg/lib/connection.js:378:17)
      at Socket.<anonymous> (/Users/bmc/src/node-pg-cursor/node_modules/pg/lib/connection.js:117:22)
      at emitOne (events.js:96:13)
      at Socket.emit (events.js:188:7)
      at readableAddChunk (_stream_readable.js:176:18)
      at Socket.Readable.push (_stream_readable.js:134:10)
      at TCP.onread (net.js:548:20)
brianc commented 7 years ago

I enabled travis for this repo too...soo...that should help. :p

sberan commented 7 years ago

@brianc thanks for enabling travis 🎉 I had to do a couple other things to get the build passing on travis, and I've also configured travis to use PG 9.6.

One strange thing is that I can't seem to get the matrix of node versions working, it always runs with node 6. Anyhow, I think this PR is good to go. 🏃

sberan commented 7 years ago

Now I see that master is using node 6 which is (I think) why the build matrix is using node 6. rebased.

sberan commented 7 years ago

@brianc anything else needed here?

sberan commented 7 years ago

@brianc ping 🔔

brianc commented 7 years ago

Gah! sorry for missing this! I get lots of incomings and up until just last week I wasn't able to process them all. Good news is I'm scaling back on full time work so I can focus more on node postgres! 👏 I'll merge this right away. Thanks a ton for both your work and your patience!!

brianc commented 7 years ago

published a new version at pg-cursor@1.2.0!!!

sberan commented 7 years ago

No problem! I know how it goes 😅thanks for all your hard work on the node Postgres ecosystem!

From: Brian C notifications@github.com Sent: Monday, May 15, 2017 11:15:57 PM To: brianc/node-pg-cursor Cc: Sam Beran; Author Subject: Re: [brianc/node-pg-cursor] Emit Query Events (#25)

Gah! sorry for missing this! I get lots of incomings and up until just last week I wasn't able to process them all. Good news is I'm scaling back on full time work so I can focus more on node postgres! 👏 I'll merge this right away. Thanks a ton for both your work and your patience!!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/brianc/node-pg-cursor/pull/25#issuecomment-301670978, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAGG4m-CXOyVvNSfh6dkTwIYazkBW7ekks5r6SL9gaJpZM4NUg14.