search

brianfrankcooper / YCSB

Yahoo! Cloud Serving Benchmark
Apache License 2.0
4.92k stars 2.23k forks source link

Rename Spanner module from "cloudspanner" to "googlespanner" for consistency #1047

Open mbrukman opened 6 years ago

mbrukman commented 6 years ago

For consistency with other Google Cloud databases which currently have the following modules:

it would be nice to rename cloudspanner -> googlespanner so that they are all consistent and sort together.

busbey commented 6 years ago

sounds reasonable. interested in working on a patch?

@siamaktz and @samizuh what do y'all think?

busbey commented 6 years ago

I started putting together a fix for this, but then I realized that the name of the product is literally "Cloud Spanner" (rather than, e.g. Google Cloud Spanner) so I think the current name is better.

Coincidentally, the names of the two other examples are actually "Cloud Bigtable" and "Cloud Datastore". So I'd still like them to be consistent, just by renaming the other two. :)

If anyone else wants to put up a PR for this, I'd appreciate it. Otherwise I'll get around to it in the next few months.

mbrukman commented 6 years ago

@busbey, as you noted, the full name of the products are "Google Cloud {Bigtable,Datastore,Spanner}", but I think it would be very long to type googlecloudbigtable or googleclouddatastore, etc. That said, just prefixing cloud to the name, i.e., cloudspanner, clouddatastore, etc. doesn't add much to help recognize what they are, which is why I was suggesting adding the google prefix.

The other alternative is to drop either the cloud or the google prefix and just call them bigtable, datastore, and spanner. I think they're known well enough to stand on their own.

Thoughts?

/cc: @dmcgrath