search

briansd9 / exile-diary

A game tracker for Path of Exile. Track literally everything that drops in your maps, and more!
https://patreon.com/briansd9
207 stars 33 forks source link

Confusion between Laboratory map and Laboratory contract #128

Closed worldendDominator closed 3 years ago

worldendDominator commented 3 years ago

"Laboratory" can be a map name and a contract name. List of areas always counts it as a map, displays Atlas region, and those heists don't count towards "Stats by Area / Heist" in Stats tab (I have all 8 other contract types there but no Laboratory).

I think they should be possible to discern by rogue small talk.

briansd9 commented 3 years ago

Hmm, to fix this, I would have to play Heist again, which I refuse to do.

Please do not expect that this will ever be fixed.

worldendDominator commented 3 years ago

Shouldn't this be as easy as "if any rogue lines are present, count as a contract"?

briansd9 commented 3 years ago

Yes, should be. Pull requests are welcome if you'd like to have a go at it yourself - relevant code is in this commit: https://github.com/briansd9/exile-diary/commit/3a9acbf077b378edc75db72fab47739de3349dcf