search

briansd9 / exile-diary

A game tracker for Path of Exile. Track literally everything that drops in your maps, and more!
https://patreon.com/briansd9
207 stars 33 forks source link

Timer in Azurite Mine doesn't stop when you exit #129

Closed worldendDominator closed 3 years ago

worldendDominator commented 3 years ago

If I log out after delving, the timer keeps counting until I log in again. Generally, the timer here counts all time until you enter a map or other area or end it manually, even if it is days later. I think the mine should use the same logic as maps: if you leave it and enter another (non-town, non-hideout) area afterwards, only the time until you left it counts.

worldendDominator commented 3 years ago

On a second thought, there's a blurry case where you delve, exit, return another day, and delve again. The only difference from "delve, hideout, delve again" or "delve, crash, relog, delve again" is the amount of time between leaving and returning.

But at least for "delve, exit, return, enter map" it should be an obvious fix.

briansd9 commented 3 years ago

Hmm, how would you propose to set the endpoint of the delve run then? Nothing is logged in Client.txt when exiting the game (either by Alt-F4, or crashing out).

worldendDominator commented 3 years ago

Ah, I didn't realize that. Looks like there's nothing to do if you just leave. However, entering a non-delve area should still be an end point if you don't reenter the mine afterwards. So if you go to HO after you finish delving, it will count as you stopping there.

briansd9 commented 3 years ago

So if you go to HO after you finish delving, it will count as you stopping there

I think this is the current behavior... it doesn't do this for you? Will review the code.

worldendDominator commented 3 years ago

Just tested it and yes, it already works like this and I didn't realize it.