briansd9 / exile-diary

A game tracker for Path of Exile. Track literally everything that drops in your maps, and more!
https://patreon.com/briansd9
207 stars 33 forks source link

fix(StashGetter): fix request for getTabList returning undefined #156

Open liujordan opened 1 year ago

liujordan commented 1 year ago

Fixes

154

153

152

Just doing a test in the browser

GET
https://www.pathofexile.com/character-window/get-stash-items?accountName=Nooders&league=Sentinel&tabs=1

returns 
{"error":{"code":1,"message":"Resource not found"}}
GET
https://www.pathofexile.com/character-window/get-stash-items?accountName=Nooders&realm=pc&league=Sentinel&tabs=1&tabIndex=0

returns
{
  "items": [...],
  "numTabs": ...,
  "tabs": [...],
  ...
}
lucastayar12 commented 1 year ago

I hope u can marge this to source code and compile for us for a new release

liujordan commented 1 year ago

That's up to @briansd9 to merge. i don't have write access

liujordan commented 1 year ago

y'all can use this release temporarily while this is being merged https://github.com/liujordan/exile-diary/releases/tag/v0.3.5

Tallion99 commented 1 year ago

Thanks liujordan for the update! Much appreciated!

Cry0nicS commented 1 year ago

@liujordan since @briansd9 is MIA, are you considering maintaining the fork for a while?