search

briansmith / ring

Safe, fast, small crypto using Rust
Other
3.64k stars 682 forks source link

Add support for 64-bit big-endian MIPS #2079

Closed matoro closed 1 month ago

matoro commented 1 month ago

This seems to have partial support in the mk scripts, but missing from target.h or CI.

briansmith commented 1 month ago

Thanks! Please try #2082 and see if that works for you. I think we don't need to add MIPSEB to the GitHub build matrix since we can't keep growing it to support every target arch.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.35%. Comparing base (8238c00) to head (a76eee6). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2079 +/- ## ========================================== + Coverage 97.24% 97.35% +0.11% ========================================== Files 144 142 -2 Lines 19995 19912 -83 Branches 228 228 ========================================== - Hits 19444 19386 -58 + Misses 525 500 -25 Partials 26 26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

matoro commented 1 month ago

Thanks! Please try #2082 and see if that works for you. I think we don't need to add MIPSEB to the GitHub build matrix since we can't keep growing it to support every target arch.

That certainly seems the better way to go, I'll close this in favor of that.