search

briansmith / webpki

WebPKI X.509 Certificate Validation in Rust
https://briansmith.org/rustdoc/webpki/
Other
464 stars 165 forks source link

Rebase verify_cert: check name constraints after sig. validation #280

Closed briansmith closed 1 year ago

briansmith commented 1 year ago

Rebase #278 on top of main after #277 was merged.

briansmith commented 1 year ago

@cpu See the last commit about the semver breakage in rcgen.

codecov[bot] commented 1 year ago

Codecov Report

Merging #280 (ed2ac06) into main (4a71d47) will increase coverage by 0.55%. Report is 3 commits behind head on main. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   50.62%   51.18%   +0.55%     
==========================================
  Files          18       18              
  Lines        3751     3806      +55     
==========================================
+ Hits         1899     1948      +49     
- Misses       1852     1858       +6
Files Coverage Δ
src/signed_data.rs 100.00% <ø> (ø)
src/verify_cert.rs 94.90% <100.00%> (+0.82%) :arrow_up:

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

cpu commented 1 year ago

@cpu See the last commit about the semver breakage in rcgen.

Thanks, I fixed that upstream but it's pending release.