Bubble change event up to other element

brianvoe / slim-select

Slim advanced select dropdown

http://slimselectjs.com

MIT License

1.03k stars 195 forks source link

Bubble change event up to other element #547

Closed frenkel closed 3 months ago

frenkel commented 3 months ago

Fixes #524.

brianvoe commented 3 months ago

I dont disagree with this. I just dont know the full ramifications. Can you add a test for it that covers a use case your trying to accomplish please?

frenkel commented 3 months ago

Sorry, but I've never written typescript before and I've also never run tests for it so that would take me quite some time to figure out. I might be able to in a few weeks time.

The situation that we're running into is that we have onchange listeners registered on a <form> tag and they don't receive any event from slim-select without bubbling but they do activate fine with bubbling. All other native elements fire events with bubbling.

frenkel commented 2 months ago

Thanks for merging this. If you want I can try to implement tests for it this week.