Require geos lib to be installed

brick / geo

GIS geometry library for PHP

MIT License

221 stars 31 forks source link

Require geos lib to be installed #2

Closed cevou closed 9 years ago

coveralls commented 9 years ago

Coverage decreased (-0.96%) when pulling c7caad3fee91122d8e5818bc1ece7f46b5ac8a72 on cevou:geos into 95567830a7aba5c8c44eb243fb981ceb8a1e0672 on brick:master.

BenMorel commented 9 years ago

@cevou It's not technically required, as there are other geometry engines only requiring a supported database, and not relying on GEOS.

Maybe we could suggest it, but I'm not even sure it's a good idea to pollute the composer output as we could also very well suggest ext-pdo and ext-sqlite3 in that case!

cevou commented 9 years ago

OK, this is true. Suggests would be could for people who wonder why the lib is not working (if they are missing the lib) but I don't mind if you just close this PR.

BenMorel commented 9 years ago

I'm going to close this for now to avoid polluting composer output as mentioned above. Some of the basic functions are actually working without a GeometryEngine set, and if someone uses a more advanced function without an engine set, they get an exception advising them to do so.

What could be useful however is to detail more what to do in the exception message.