search

brickbots / PiFinder

A plate solving telescope finder based around a Raspberry PI and RPI HQ Camera
GNU General Public License v3.0
161 stars 31 forks source link

Populate_wifi_networks() in sys_utils fails when networks or password contain equal signs #238

Closed jscheidtmann closed 2 months ago

jscheidtmann commented 2 months ago

Sys_utils.py line 50 uses string.split(„=„) which is wrong and fails, if any line contains additional equal signs.

mrosseel commented 2 months ago

should probably refactor this to use dbus communication to networkmanager - cleaner than changing config files and we might be able to avoid some reboots

jscheidtmann commented 2 months ago

Maybe you can create a different ticket for that? This one needs fixed, as this kills the process and user(s) on Discord report(s) a hanging PiFinder.

mrosseel commented 2 months ago

working on it

brickbots commented 2 months ago

should probably refactor this to use dbus communication to networkmanager - cleaner than changing config files and we might be able to avoid some reboots

When we finally finish moving to the new version of Raspberry Pi OS, there is a totally new network management system. I have it roughed in a Bookworm branch, but it's been a long time..... So let's not make any big changes here until we move to the new OS

Thanks for the quick parsing fix!

brickbots commented 2 months ago

Merged #239