bricobio / bricobio-website

Development for bricobio.com / bricobio.github.io
MIT License
2 stars 2 forks source link

posts/_data.json is not storing authors efficiently #7

Closed zafarali closed 10 years ago

zafarali commented 10 years ago

Hi I just wanted to bring it up that the _data.json file that holds blog posts is not storing the authors correctly. This should be rectified immediately to make it future proof. Ideally what is now this:

{
        "author": {
            "author_1": "Thomas Ingalls",
            "author_2": "Kevin Chen"
        },
        "authorsocialprofile": {
            "authorsocialprofile_1": "http://www.twitter.com/thomasingalls",
            "authorsocialprofile_2": "http://www.twitter.com/bkevinchen"
        },
}

Should be:

{
"author":[ "Thomas Ingalls","Kevin Chen"],
"authorprofile": ["http://www.twitter.com/thomasingalls", "http://www.twitter.com/bkevinchen"],
}

Reasons:

Please give the go ahead and I can change the _data.json file WARN: I am not sure how you write the the blog posts. If it is manual then this will go off without a problem, if you have something that automatically encodes it for you then that needs to be changed too to ensure consistency.

thomasingalls commented 10 years ago

everything is manual until we automate parts ourselves in jade

yes please change author storage format - it's something I've wanted to fix

feel free to add/modify/augment the blog section. it's a boilerplate I inserted with very little modification. On Jun 17, 2014 9:31 PM, "Zafarali Ahmed" notifications@github.com wrote:

Hi I just wanted to bring it up that the _data.json file that holds blog posts is not storing the authors correctly. This should be rectified immediately to make it future proof. Ideally what is now this:

... "author": { "author_1": "Thomas Ingalls", "author_2": "Kevin Chen" }, "authorsocialprofile": { "authorsocialprofile_1": "http://www.twitter.com/thomasingalls", "authorsocialprofile_2": "http://www.twitter.com/bkevinchen" },...

Should be:

"author":[ "Thomas Ingalls","Kevin Chen"],"authorprofile": ["http://www.twitter.com/thomasingalls", "http://www.twitter.com/bkevinchen"],

Reasons:

  • Makes it easier to iterate over the authors
  • allows us to account for things like and's and comma's
  • Saves space when storing it.

Please give the go ahead and I can change the _data.json file WARN: I am not sure how you write the the blog posts. If it is manual then this will go off without a problem, if you have something that automatically encodes it for you then that needs to be changed too to ensure consistency.

— Reply to this email directly or view it on GitHub https://github.com/bricobio/bricobio-website/issues/7.

zafarali commented 10 years ago

Done. I have updated the template to reflect what it should really be like, but for future ease of access here it is:

{ 
"template-for-posts": {
        "title": "",
        "summary": "",
        "date_published": "",
        "date_updated": "",
        "authors": [""],
        "authorprofile": [""],
        "thumbnail": ""
    }
}