bridgecrewio / checkov

Prevent cloud misconfigurations and find vulnerabilities during build-time in infrastructure as code, container images and open source packages with Checkov by Bridgecrew.
https://www.checkov.io/
Apache License 2.0
7.17k stars 1.12k forks source link

fix(secrets): masking test format #6859

Closed matansha closed 1 week ago

matansha commented 1 week ago

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[//]: # "

PR Title

We use the title to create changelog automatically and therefore only allow specific prefixes
- break:    to indicate a breaking change, this supersedes any of the other types
- feat:     to indicate new features or checks
- fix:      to indicate a bugfix or handling of edge cases of existing checks
- docs:     to indicate an update to our documentation
- chore:    to indicate adjustments to workflow files or dependency updates
- platform: to indicate a change needed for the platform
Each prefix should be accompanied by a scope that specifies the targeted framework. If uncertain, use 'general'.
#    
Allowed prefixs:
ansible|argo|arm|azure|bicep|bitbucket|circleci|cloudformation|dockerfile|github|gha|gitlab|helm|kubernetes|kustomize|openapi|sast|sca|secrets|serverless|terraform|general|graph|terraform_plan|terraform_json
#
ex.
feat(terraform): add CKV_AWS_123 to ensure that VPC Endpoint Service is configured for Manual Acceptance

"

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:


Generated description

Below is a concise technical summary of the changes proposed in this PR:

Refactor the JSON structure in the tests/secrets/masking_secrets directory to improve readability and maintainability. The changes involve restructuring the JSON objects in assets_report_with_pass.json and findings_report_with_pass.json by removing redundant fields and simplifying the nested structures. This update aims to enhance the clarity of the data representation, particularly focusing on the aws_instance.web_host resource, which is used for testing secret masking in Terraform configurations.

<table><tr><th>Topic</th><th>Details</th><tr><td><a href=https://baz.co/changes/bridgecrewio/checkov/6859?tool=ast&topic=Assets+Report+Refactor>Assets Report Refactor</a>
    </td><td>Simplify JSON structure in <code>assets_report_with_pass.json</code> by removing redundant fields and restructuring nested objects for better readability and maintainability.<details><summary>Modified files (1)</summary><ul><li>tests/secrets/masking_secrets/assets_report_with_pass.json</li></ul></details><details><summary>Latest Contributors(1)</summary><table><tr><th>User</th><th>Commit</th><th>Date</th></tr><tr><td>matanshati@gmail.com</td><td>feat-secrets-Masking-s...</td><td>November 17, 2024</td></tr></table></details></td></tr>
Findings Report Refactor Refactor findings_report_with_pass.json to streamline the JSON structure, focusing on the aws_instance.web_host resource, and remove unnecessary fields to enhance clarity.
Modified files (1)
  • tests/secrets/masking_secrets/findings_report_with_pass.json
Latest Contributors(1)
UserCommitDate
matanshati@gmail.comfeat-secrets-Masking-s...November 17, 2024
This pull request is reviewed by Baz. Join @matansha and the rest of your team on (Baz).