search

bridgedb / BridgeDb

The BridgeDb Library source code
https://bridgedb.org/
Apache License 2.0
28 stars 21 forks source link

2 tests DataSourcePatterns class #237

Closed youphendriks closed 5 months ago

youphendriks commented 6 months ago

Valid input working, invalid input Disabled cause I have to figure out how to throws. getDataSourceMatches class does not throw an exception on following inputs; "", " " Is there a different method to make my test throw an exception or is the problem the lack of exception handling in the codebase?

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 19.95%. Comparing base (3c039ec) to head (5038cd5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #237 +/- ## ========================================== + Coverage 19.93% 19.95% +0.01% ========================================== Files 164 164 Lines 10542 10542 Branches 1403 1403 ========================================== + Hits 2102 2104 +2 + Misses 8245 8242 -3 - Partials 195 196 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

egonw commented 6 months ago

Is there a different method to make my test throw an exception or is the problem the lack of exception handling in the codebase?

I need a bit more explanation here, because I am not sure what you mean.

youphendriks commented 6 months ago

Implemented changes: added "." to JavaDoc and changed name and email to mine. I believe this commit has been added to the PR, could you check?

egonw commented 5 months ago

Thanks, merged! I updated the copyright year (since you write it this year) and some formatting. We should have a template for the copyright/license header and then apply it to all files. Right now, many still are a mix of copyright/license and documentation (the last should be in the JavaDoc instead, in my opinion).

youphendriks commented 5 months ago

Good to know I should also update the copyright year, I was not sure if I should do this. I’ll set up a template and start making it uniform. Today I will work on implementing mockito, I’ll keep you posted!

From: Egon Willighagen @.> Sent: Monday, March 4, 2024 6:41:02 AM To: bridgedb/BridgeDb @.> Cc: Youp Hendriks @.>; Author @.> Subject: Re: [bridgedb/BridgeDb] 2 tests DataSourcePatterns class (PR #237)

Thanks, merged! I updated the copyright year (since you write it this year) and some formatting. We should have a template for the copyright/license header and then apply it to all files. Right now, many still are a mix of copyright/license and documentation (the last should be in the JavaDoc instead, in my opinion).

— Reply to this email directly, view it on GitHubhttps://github.com/bridgedb/BridgeDb/pull/237#issuecomment-1975771581, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AK7FBZFRY57HCHILLM6C4S3YWQCO5AVCNFSM6AAAAABD6MDSYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVG43TCNJYGE. You are receiving this because you authored the thread.Message ID: @.***>