search

briggySmalls / cookiecutter-pypackage

Cookiecutter template for a poetry-managed Python package.
BSD 3-Clause "New" or "Revised" License
71 stars 34 forks source link

tox fails, can't find setup.py #21

Closed joeydumont closed 4 years ago

joeydumont commented 4 years ago

Description

I created a new project with this cookiecutter template, and ran tox immediately afterward on the generated project. This failed with

$ tox
ERROR: No setup.py file found. The expected location is:
  <redacted>/setup.py
You can
  1. Create one:
     https://packaging.python.org/tutorials/distributing-packages/#setup-py
  2. Configure tox to avoid running sdist:
     https://tox.readthedocs.io/en/latest/example/general.html#avoiding-expensive-sdist
briggySmalls commented 4 years ago

Thanks for your bug report. I'm sorry about that! I just underwent quite a big conversion from using pipenv to poetry and I am still fixing bugs here and there.

I'm looking into this one now!

briggySmalls commented 4 years ago

Hi there 👋

I think I've found the issue and will be merging the fix soon.

If you want to get your already-generated package to work you can look at PR #22 for the changes you'll need. They are quite small and mainly follow the poetry FAQ on the topic that I should have read by now!

Thanks again for your issue. I hope you find the project useful!

joeydumont commented 4 years ago

Thanks, I implemented the fix manually in my project and it worked!

briggySmalls commented 4 years ago

Sensational! 🎆