briis / smartweather

WeatherFlow Smart Weather Component for Home Assistant
MIT License
108 stars 11 forks source link

Weather State #47

Closed ryan-mcxx closed 3 years ago

ryan-mcxx commented 3 years ago

Since upgrading to 2.0.5 the state of the weather entity is displaying "pouring" when it is raining at all or rain is likely per the Tempest app

briis commented 3 years ago

The condition and icons should map to the 'official' way WeatherFlow has defined it. When the weather entity is displaying "pouring", could you go in to the Developer Tools, and search for the weather entity. Here you will find an attribute called current_icon and then tell me what the value is. I need to check if I messed up the mapping.

ryan-mcxx commented 3 years ago

Here is what it is showing for me, let me know if there is anything else you need. Thanks!

temperature: 46.22 humidity: 93 pressure: 30.43 wind_bearing: 334 wind_speed: 2 attribution: Powered by a WeatherFlow Smart Weather Station forecast:

briis commented 3 years ago

Found the error - rainy was mapping to both rainy and pouring. Need to figure out what is send from the API when it is pouring. I'll release something as soon as it is fixed.

briis commented 3 years ago

Basically "pouring" does not exist in WeatherFlow terms. We have 3 possible conditions:

In HA there is only rainy and pouring, so I will remove pouring from the mapping. Do you agree with this solution?

ryan-mcxx commented 3 years ago

Yes that makes sense. I guess I'm not sure why it is saying its "pouring" if it is not currently raining. It seems like it chooses "rainy" if the precipitation probability is >=50 based off the first few entries?

briis commented 3 years ago

The value that comes from the API is out of my control - Weatherflow says they are AI based, so hopefully they will get better over time. Btw, the Forecast API is still not officially released, so some changes might occur when that happens.

I'll make the changes, and send a new release. (Have a few other things I am working on with this, so it might take a few days)

ryan-mcxx commented 3 years ago

No worries, just thought I'd point it out. Thanks!

briis commented 3 years ago

Closed with the release of V2.1. Let me know if you still see the problem