search

brillout / awesome-vue-refactor

A curated list of awesome things related to Vue.js
37 stars 15 forks source link

vue-audio removed, why #39

Open shershen08 opened 7 years ago

shershen08 commented 7 years ago

referencing this https://github.com/vuejs/awesome-vue/pull/1001#issue-217693898

One of my vue.js libs that has 30+ stars (not a big deal surely) is marked as "vue-audio ★9 too specific" - what do you mean? ppl use it so why not?

My question is - what's the problem with this one? Why it was removed? The only misguidance I saw is missing a CONTRUBITING section - is that such a big of a deal for some random lib to be excluded? doesnt's the default path work - fork and create a PR ... this looks like a bureaucracy a bit to me if that's the problem.

I've checked further for the label "too specific" and saw some other libs doing some other types of improvements/UI. it looks pretty strange to me that someone states that some lib is too specific in open source. if you didn't deal with some area why you'd make this statement?

Ffloriel commented 7 years ago

In previous comments, too specific meant that the problem solved by the library was too specific. I looked at your lib and it seems to be a bit specific indeed. Tell me if I am wrong in my description.

It is a library that encapsulates the audio tag api within a vuejs component. You need to use bootstrap css in your project or adding it for the component to render properly. I might be wrong but it seems that the styling can not be customize (at least not meant to).
If I don't want the default audio tag ui , I am using bootstrap and I like this particular ui then this component is the right fit for me. To be clear, it does not mean that your component is bad or useless.

A recurrent problem is a lack of description of some libraries. One thing that you could add to the description is why people need or would want to use the lib, what is the value of it? In your case, why would I not use the default audio tag, does the lib do something more? Can I modify the ui of the component more easily than the default tag?

shershen08 commented 7 years ago

Thank for the details, @Ffloriel

However I see that usefulness of abstraction of any API even without adding new functionality is a common approach in building small single purpose components. In this particular case of the audio tag the added value is that with vue-audioyou can control the tag API from your vue code, not having to write and test your own boilerplate.

Yes, I think adding more flexibility to UI could be a good option. I'll work on that coming days and we'll get back to that, OK ?

Ffloriel commented 7 years ago

If you want to improve vue-audio, I don't think someone will object :)
I am not the one that remove your component and @brillout might have other reasons. Improving the Readme, maybe provide an example of how to use the component, and removing the need to use bootstrap will definitely improve the lib.

brillout commented 7 years ago

Hi @shershen08, thanks for opening the issue.

I agree with @Ffloriel.

The readme doesn't mention how to customize the UI hence I'm assuming that I can't.

I see that usefulness of abstraction of any API even without adding new functionality

I agree but from reading the readme it's not what I understood what your project is about.

Basically the only thing I can do with your library without reading its source code is to display the player shown in https://shershen08.github.io/vue-plugins-demo-static/index.html#/sound. And that's too specific to be called a library, i.e. it's more a demo than a library.

Feel free to re-submit your project once our concerns are addressed.