search

brimworks / lua-ev

Lua integration with libev.
MIT License
225 stars 55 forks source link

Make package building with Lua 5.4 #24

Open mcepl opened 4 years ago

mcepl commented 4 years ago

There are versions of Lua hard-coded into cmake/Modules/FindLua5X.cmake and Lua 5.4 is missing. Why don’t you use standard cmake/Modules/FindLua.cmake, by the way?

Anyway, this patch works around this problem.

mcepl commented 4 years ago

Hmm, even with this patch, the test suite fails:

[   29s] + /usr/bin/ctest --force-new-ctest-process --extra-verbose
[   29s] UpdateCTestConfiguration  from :/home/abuild/rpmbuild/BUILD/lua-ev-1.5/build/DartConfiguration.tcl
[   29s] Parse Config file:/home/abuild/rpmbuild/BUILD/lua-ev-1.5/build/DartConfiguration.tcl
[   29s] UpdateCTestConfiguration  from :/home/abuild/rpmbuild/BUILD/lua-ev-1.5/build/DartConfiguration.tcl
[   29s] Parse Config file:/home/abuild/rpmbuild/BUILD/lua-ev-1.5/build/DartConfiguration.tcl
[   29s] Test project /home/abuild/rpmbuild/BUILD/lua-ev-1.5/build
[   29s] Constructing a list of tests
[   29s] Done constructing a list of tests
[   29s] Updating test list for fixtures
[   29s] Added 0 tests to meet fixture requirements
[   29s] Checking test dependency graph...
[   29s] Checking test dependency graph end
[   29s] test 1
[   29s]     Start 1: ev_io
[   29s] 
[   29s] 1: Test command: /usr/bin/lua "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/test_ev_io.lua" "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/" "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/build/"
[   29s] 1: Test timeout computed to be: 1500
[   29s] 1: 1..??
[   29s] 1: /usr/bin/lua: /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/tap.lua:1: attempt to call a nil value (global 'module')
[   29s] 1: stack traceback:
[   29s] 1:     /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/tap.lua:1: in main chunk
[   29s] 1:     [C]: in function 'require'
[   29s] 1:     /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/test_ev_io.lua:14: in main chunk
[   29s] 1:     [C]: in ?
[   29s] 1/7 Test #1: ev_io ............................***Failed    0.00 sec
[   29s] test 2
[   29s]     Start 2: ev_loop
[   29s] 
[   29s] 2: Test command: /usr/bin/lua "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/test_ev_loop.lua" "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/" "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/build/"
[   29s] 2: Test timeout computed to be: 1500
[   29s] 2: /usr/bin/lua: /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/tap.lua:1: attempt to call a nil value (global 'module')
[   29s] 2: stack traceback:
[   29s] 2:     /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/tap.lua:1: in main chunk
[   29s] 2:     [C]: in function 'require'
[   29s] 2:     ...e/abuild/rpmbuild/BUILD/lua-ev-1.5/test/test_ev_loop.lua:5: in main chunk
[   29s] 2:     [C]: in ?
[   29s] 2/7 Test #2: ev_loop ..........................***Failed    0.00 sec
[   29s] test 3
[   29s]     Start 3: ev_timer
[   29s] 
[   29s] 3: Test command: /usr/bin/lua "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/test_ev_timer.lua" "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/" "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/build/"
[   29s] 3: Test timeout computed to be: 1500
[   29s] 3: 1..20
[   29s] 3: /usr/bin/lua: /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/tap.lua:1: attempt to call a nil value (global 'module')
[   29s] 3: stack traceback:
[   29s] 3:     /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/tap.lua:1: in main chunk
[   29s] 3:     [C]: in function 'require'
[   29s] 3:     .../abuild/rpmbuild/BUILD/lua-ev-1.5/test/test_ev_timer.lua:7: in main chunk
[   29s] 3:     [C]: in ?
[   29s] 3/7 Test #3: ev_timer .........................***Failed    0.00 sec
[   29s] test 4
[   29s]     Start 4: ev_idle
[   29s] 
[   29s] 4: Test command: /usr/bin/lua "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/test_ev_idle.lua" "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/" "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/build/"
[   29s] 4: Test timeout computed to be: 1500
[   29s] 4: 1..17
[   29s] 4: /usr/bin/lua: /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/tap.lua:1: attempt to call a nil value (global 'module')
[   29s] 4: stack traceback:
[   29s] 4:     /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/tap.lua:1: in main chunk
[   29s] 4:     [C]: in function 'require'
[   29s] 4:     ...e/abuild/rpmbuild/BUILD/lua-ev-1.5/test/test_ev_idle.lua:7: in main chunk
[   29s] 4:     [C]: in ?
[   29s] 4/7 Test #4: ev_idle ..........................***Failed    0.00 sec
[   29s] test 5
[   29s]     Start 5: ev_signal
[   29s] 
[   29s] 5: Test command: /usr/bin/lua "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/test_ev_signal.lua" "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/" "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/build/"
[   29s] 5: Test timeout computed to be: 1500
[   29s] 5: 1..17
[   29s] 5: /usr/bin/lua: /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/tap.lua:1: attempt to call a nil value (global 'module')
[   29s] 5: stack traceback:
[   29s] 5:     /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/tap.lua:1: in main chunk
[   29s] 5:     [C]: in function 'require'
[   29s] 5:     ...abuild/rpmbuild/BUILD/lua-ev-1.5/test/test_ev_signal.lua:7: in main chunk
[   29s] 5:     [C]: in ?
[   29s] 5/7 Test #5: ev_signal ........................***Failed    0.00 sec
[   29s] test 6
[   29s]     Start 6: ev_child
[   29s] 
[   29s] 6: Test command: /usr/bin/lua "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/test_ev_child.lua" "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/" "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/build/"
[   29s] 6: Test timeout computed to be: 1500
[   29s] 6: /usr/bin/lua: /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/tap.lua:1: attempt to call a nil value (global 'module')
[   29s] 6: stack traceback:
[   29s] 6:     /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/tap.lua:1: in main chunk
[   29s] 6:     [C]: in function 'require'
[   29s] 6:     .../abuild/rpmbuild/BUILD/lua-ev-1.5/test/test_ev_child.lua:5: in main chunk
[   29s] 6:     [C]: in ?
[   29s] 6/7 Test #6: ev_child .........................***Failed    0.00 sec
[   29s] test 7
[   29s]     Start 7: ev_stat
[   29s] 
[   29s] 7: Test command: /usr/bin/lua "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/test_ev_stat.lua" "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/" "/home/abuild/rpmbuild/BUILD/lua-ev-1.5/build/"
[   29s] 7: Test timeout computed to be: 1500
[   29s] 7: /usr/bin/lua: /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/tap.lua:1: attempt to call a nil value (global 'module')
[   29s] 7: stack traceback:
[   29s] 7:     /home/abuild/rpmbuild/BUILD/lua-ev-1.5/test/tap.lua:1: in main chunk
[   29s] 7:     [C]: in function 'require'
[   29s] 7:     ...e/abuild/rpmbuild/BUILD/lua-ev-1.5/test/test_ev_stat.lua:5: in main chunk
[   29s] 7:     [C]: in ?
[   29s] 7/7 Test #7: ev_stat ..........................***Failed    0.00 sec
[   29s] 
[   29s] 0% tests passed, 7 tests failed out of 7
[   29s] 
[   29s] Total Test time (real) =   0.01 sec
[   29s] 
[   29s] The following tests FAILED:
[   29s]      1 - ev_io (Failed)
[   29s]      2 - ev_loop (Failed)
[   29s]      3 - ev_timer (Failed)
[   29s]      4 - ev_idle (Failed)
[   29s]      5 - ev_signal (Failed)
[   29s]      6 - ev_child (Failed)
[   29s]      7 - ev_stat (Failed)
[   29s] Errors while running CTest

Any ideas what I am doing wrong, please?