search

britannio / in_app_review

A Flutter plugin for showing the In-App Review/System Rating pop up on Android, IOS, and MacOS. It makes it easy for users to rate your app.
327 stars 82 forks source link

Fails to build on external device #78

Open albercode10 opened 2 years ago

albercode10 commented 2 years ago

This only happens when the package is added (ver 2.0.5)

FAILURE: Build failed with an exception.

britannio commented 2 years ago

This library implements com.google.android.play:review:2.0.1.

Are you using other play libraries such as In-App updates, Play Asset Delivery, Play Feature Delivery etc?

You mentioned building on an external device. Presumably, the issue also occurs if you build an APK or app bundle?

albercode10 commented 2 years ago

Im not using any of those libraries that i know of. it happens when connecting a external phone to Android studio and running the app.

This are my dependencies: dependencies: flutter: sdk: flutter flutter_localizations: sdk: flutter cupertino_icons: ^1.0.5 flip_card: ^0.6.0 sqflite: ^2.2.0+3 path_provider: ^2.0.11 intl: ^0.17.0 flutter_bloc: ^8.1.1 equatable: ^2.0.5 share_plus: ^6.2.0 url_launcher: ^6.1.6 shared_preferences: ^2.0.15 sensors_plus: ^2.0.1 devicelocale: ^0.5.5 overlay_support: ^2.0.1 dynamic_color: ^1.5.4 flutter_native_splash: ^2.2.14 flutter_svg: ^1.1.6 auto_size_text: ^3.0.0 store_redirect: ^2.0.1

jagmohanSB commented 2 years ago

i am having the same issue is there any solution i am using the in-app update plugin as well @britannio

sitaram-gupta commented 2 years ago

Same issue! Conflicting the same modules with firebase_core dependency as named duplicates, waiting for the solution.

britannio commented 2 years ago

Im not using any of those libraries that i know of. it happens when connecting a external phone to Android studio and running the app.

This are my dependencies: dependencies: flutter: sdk: flutter flutter_localizations: sdk: flutter cupertino_icons: ^1.0.5 flip_card: ^0.6.0 sqflite: ^2.2.0+3 path_provider: ^2.0.11 intl: ^0.17.0 flutter_bloc: ^8.1.1 equatable: ^2.0.5 share_plus: ^6.2.0 url_launcher: ^6.1.6 shared_preferences: ^2.0.15 sensors_plus: ^2.0.1 devicelocale: ^0.5.5 overlay_support: ^2.0.1 dynamic_color: ^1.5.4 flutter_native_splash: ^2.2.14 flutter_svg: ^1.1.6 auto_size_text: ^3.0.0 store_redirect: ^2.0.1

I was unable to reproduce the issue by adding these packages to the example app then running flutter clean && flutter pub get && flutter build apk

daksh-pokar-shipsy commented 2 years ago

Yes can verify facing this

`Execution failed for task ':app:checkReleaseDuplicateClasses'.

A failure occurred while executing com.android.build.gradle.internal.tasks.CheckDuplicatesRunnable Duplicate class com.google.android.play.core.common.IntentSenderForResultStarter found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-core-common-2.0.2-runtime (com.google.android.play:core-common:2.0.2) Duplicate class com.google.android.play.core.common.LocalTestingException found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-core-common-2.0.2-runtime (com.google.android.play:core-common:2.0.2) Duplicate class com.google.android.play.core.common.PlayCoreDialogWrapperActivity found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-core-common-2.0.2-runtime (com.google.android.play:core-common:2.0.2) Duplicate class com.google.android.play.core.listener.StateUpdatedListener found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-core-common-2.0.2-runtime (com.google.android.play:core-common:2.0.2) Duplicate class com.google.android.play.core.review.ReviewException found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.ReviewInfo found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.ReviewManager found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.ReviewManagerFactory found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.model.ReviewErrorCode found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.model.zza found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.testing.FakeReviewManager found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.zza found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.zzb found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.zzc found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.zzd found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.zze found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.zzf found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.zzg found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.zzh found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) Duplicate class com.google.android.play.core.review.zzi found in modules jetified-core-1.10.3-runtime (com.google.android.play:core:1.10.3) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1) `

britannio commented 2 years ago

Is there a particular Flutter package this is incompatible with?

britannio commented 2 years ago

I'd be curious if anyone is able to break the build of the example app by updating https://github.com/britannio/in_app_review/blob/master/in_app_review/example/pubspec.yaml.

daksh-pokar-shipsy commented 2 years ago

Will try to check this, up until that I am trying to build by disabling each and every dependency one by one and keeping in_app_review.

Here are my dependencies for reference - 

dependencies:
  pdf_render: ^1.3.0
  animated_flip_counter: ^0.2.4
  animations: ^2.0.2
  badges: ^2.0.3
  barcode_scan2: ^4.2.1
  bloc: ^8.0.3
  bloc_concurrency: ^0.2.0
  cached_network_image: ^3.2.0
  connectivity_plus: ^2.3.6
  country_icons: ^2.0.2
  dotted_border: ^2.0.0+2
  easy_localization: ^3.0.0
  flutter:
    sdk: flutter
  flutter_bloc: ^8.0.1
  flutter_local_notifications: ^9.5.3+1
  flutter_localizations:
    sdk: flutter
  flutter_staggered_animations: ^1.0.0
  flutter_svg: ^1.0.3
  fluttertoast: ^8.0.8
  firebase_core: ^1.24.0
  firebase_analytics: ^9.1.0
  firebase_messaging: ^12.0.1
  firebase_crashlytics: ^2.8.2
  file_picker: ^4.4.0
  form_field_validator: ^1.1.0
  geocoding: ^2.0.2
  geolocator: ^8.2.1
  get_it: ^7.2.0
  google_geocoding: ^0.2.0
  google_maps_flutter: ^2.1.10
  image_picker: '0.8.4+9'
  in_app_review: ^2.0.6
  in_app_update: ^3.0.0
  intl: ^0.17.0
  new_version: ^0.3.1
  package_info_plus: ^1.4.0
  pin_code_fields: ^7.4.0
  provider: ^6.0.3
  retry: ^3.1.0
  share_plus: ^4.0.10
  shared_preferences: ^2.0.15
  showcaseview: ^1.1.7
  sliding_up_panel: ^2.0.0+1
  url_launcher: ^6.1.5
  webview_flutter: ^3.0.4
nikb7 commented 2 years ago

if you are using in_app_update library, you have to update that as well. Both libs have updated google play dependencies. If you update 1 lib and not the other that cause the conflict. We were able to resolve this by updating both the libs.

nikb7 commented 2 years ago

@daksh-pokar-shipsy update in_app_update to ^4.0.1

nikb7 commented 2 years ago

@britannio maybe you can release this change as major update and change the lib version to 3.0.0. So other don't end up just upgrade this library and running into this error. Or we can update the documentation for this.

daksh-pokar-shipsy commented 2 years ago

@nikb7 Will try this, I have to update some other dependencies first to accomplish this.

nikb7 commented 2 years ago

You can use version 2.0.4 of in_app_review in the meantime @daksh-pokar-shipsy This will work with in_app_update: ^3.0.0

daksh-pokar-shipsy commented 2 years ago

Cool that works, thanks.👍

sitaram-gupta commented 1 year ago

@nikb7 @daksh-pokar-shipsy Actually, it's hard to match versions of two packages 

 firebase_core: ^2.3.0
 firebase_crashlytics: ^3.0.6
 firebase_messaging: ^14.1.2
  with
in_app_review: ^2.0.6
native_updater: ^0.1.1

in_app_review should have mentioned matching versions.

Simon-PumpAndUp commented 1 year ago

Same here:

jetified-core-1.9.1-runtime (com.google.android.play:core:1.9.1) and jetified-core-common-2.0.2-runtime (com.google.android.play:core-common:2.0.2
jetified-core-1.9.1-runtime (com.google.android.play:core:1.9.1) and jetified-review-2.0.1-runtime (com.google.android.play:review:2.0.1)

I believe the package is just not well configured regarding the underlying dependencies it uses.

In the meantime, the issue is that you have two or more dependencies using different versions of an underlying dependency.

To resolve this on your side check this answer: https://stackoverflow.com/a/67049254

yashwp commented 1 year ago

My build got fixed by updating packages:

in_app_review: ^2.0.6
in_app_update: ^4.0.1