search

brodieG / diffobj

Compare R Objects with a Diff
229 stars 12 forks source link

more strict namespacing for row class, closes #127 #128

Closed cpsievert closed 6 years ago

brodieG commented 6 years ago

Thanks for taking the time to debug this. Figuring out CSS conflicts is one of my least favorite activities.

The PR looks good, but I have a couple of requests:

  1. Do you mind making the PR against the development branch (this is in CONTRIBUTING.md, though I'll admit I've failed to read the CONTRIBUTING.md in other projects myself in the past)?
  2. (optional) Add an entry to NEWS.md crediting yourself?

Alternatively, I'm happy to just make the changes directly myself, but obviously then the only credit you get is what I put in NEWS instead of showing up as a contributor. Let me know how you prefer to go forward with this.

cpsievert commented 6 years ago

Go ahead and make the changes yourself and credit me however you wish

brodieG commented 6 years ago

Ok, will do, thanks for your help.