search

brodycj / ask-me-anything

ASK ME ANYTHING such as support, ideas, or personal questions
Creative Commons Attribution 4.0 International
4 stars 1 forks source link

Testing prettier with Typescript 4.1 beta #31

Closed sandersn closed 4 years ago

sandersn commented 4 years ago

Are you still contributing to prettier? Prettier is JS code type-checked with Typescript, and I changed the way CommonJS imports work in 4.1. It turns out the prettier is the only code I could find that used nested destructuring with a require call:

const { utils: { nub, intercalate } } = require('./monopackage')

I restored the old behaviour for this pattern in https://github.com/microsoft/TypeScript/pull/40188 — it's a lot of work to support it correctly — but I'd like somebody on the prettier project to test it and make sure it works the same as it used to. Is that something you could do or can you point me to a good person?

brodycj commented 4 years ago

I guess we will continue discussion in https://github.com/microsoft/TypeScript/issues/40578.

Thanks Nathan for your efforts to support Prettier. I contribute whenever I can, which is generally not as much as I would like. Please feel free to ask again, any time.