Adds SoftwareProcess.SSH_ADDRESS (user@ip:port)

brooklyncentral / brooklyn

This project has moved and is now part of the ASF

https://github.com/apache/incubator-brooklyn

72 stars 27 forks source link

Adds SoftwareProcess.SSH_ADDRESS (user@ip:port) #1430

Closed aledsage closed 10 years ago

aledsage commented 10 years ago

particularly useful for docker, where the ssh port is mapped so no each way of finding out that port otherwise

aledsage commented 10 years ago

@andreaturli @grkvlt @richardcloudsoft could one of you take a look please?

ahgittin commented 10 years ago

Feels leaky to me putting this on SwProc as ssh is driver-specific, in theory and occasionally. Could this go in Attributes instead and be a dynamic sensor (ie not declared on interface here).

Also I wonder should this be strongly typed with a nice tostring instead of always a string?

(have not looked at code as am on airplane)

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2372 FAILURE Looks like there's a problem with this pull request (what's this?)

aledsage commented 10 years ago

@ahgittin have incorporated your comments.

The previous failure for RebindCatalogEntityTest.testRestoresAppFromCatalogClassloader looks unrelated to these changes - we should address that in a separate PR.

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2391 SUCCESS This pull request looks good (what's this?)

aledsage commented 10 years ago

Merging as need this on-site with customer; let me know if you have any more comments though.