search

brooklyncentral / brooklyn

This project has moved and is now part of the ASF
https://github.com/apache/incubator-brooklyn
72 stars 27 forks source link

fixed #1464 - change so persistence dir is only backed up if node is HA ... #1477

Closed ahgittin closed 10 years ago

ahgittin commented 10 years ago

...master or HA disabled; handles the case of HA autodetect selecting master hence the complexity.

also fixes some leaks in test and improves atomic file update support in FileBasedObjectStore. (incorporates new logging from #1469)

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2507 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2510 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2511 SUCCESS This pull request looks good (what's this?)

buildhive commented 10 years ago

Brooklyn Central » brooklyn #2513 SUCCESS This pull request looks good (what's this?)

ahgittin commented 10 years ago

needed to fix some problems so merging, please review-after-commit @aledsage

ahgittin commented 10 years ago

i can fix that -- any other comments @aledsage ?

aledsage commented 10 years ago

Have finished reviewing - lots of good stuff here. Biggest comment is that need to better understand the use-cases around PersistenceObjectStore.prepareForUse and PersistenceObjectStore.prepareForContendedWrite - are these covered sufficiently by unit/integration tests?

ahgittin commented 10 years ago

agree with pretty much all comments, and updated. will open new PR against apache.