feat(winner-display): add end game dialog - Githubissues

broology / poker-moons

Free online poker with friends without the hassle.

4 stars 3 forks source link

feat(winner-display): add end game dialog #256

Closed jordems closed 1 year ago

jordems commented 1 year ago

Proposed Changes

Fixes issue where end game state was not hit consitently from a race condition.
Adds simple dialog message to display that the game has ended.
Hides players action panel when winner display is active
Fixes dialogs to always typography

Linked Issue

*resolves #247

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Merge Checklist

[x] My code follows the code style of this project.
[x] All new and existing tests passed.
[x] Any dependent changes have been merged in downstream modules.
[x] I have provided inline technical documentation (tsdocs) where necessary.
[ ] My change requires a change to the root documentation.
[ ] I have updated the documentation accordingly.

Deployment Notes