feat: display players cards at the end of the game - Githubissues

broology / poker-moons

Free online poker with friends without the hassle.

4 stars 3 forks source link

feat: display players cards at the end of the game #264

Closed jordems closed 1 year ago

jordems commented 1 year ago

Proposed Changes

Easier than I thought. The rule is if the winners are being evaluated and more than 1 player is in contention, then the cards should be displayed.

Also fixed a frontend bug with the dialog display at the end of rounds.

Linked Issue

resolves #241

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Merge Checklist

[x] My code follows the code style of this project.
[x] All new and existing tests passed.
[ ] Any dependent changes have been merged in downstream modules.
[x] I have provided inline technical documentation (tsdocs) where necessary.
[ ] My change requires a change to the root documentation.
[ ] I have updated the documentation accordingly.

Deployment Notes

jordems commented 1 year ago

Emit cards when autocomplete occurs