Angular 15 compatibility & ChangeDetection on cheatsheet toggle

brtnshrdr / angular2-hotkeys

Keyboard shortcuts for Angular 2 apps

MIT License

203 stars 95 forks source link

Angular 15 compatibility & ChangeDetection on cheatsheet toggle #168

Closed ilueckel closed 1 year ago

ilueckel commented 1 year ago

This merge requests adds

build support for Angular 15
Changes the cheatsheet toggle to a behavior subject to make use of the build in angular change detection. Otherwise I head to evaluate to complete view for changes just to toggle the cheatsheet

Coffee-Tea commented 1 year ago

Hey @ilueckel! Thanks for this great PR. Looks good for me.

Just to double-check was it tested in your project locally?

ilueckel commented 1 year ago

Hi @Coffee-Tea, I published it to my local npm repository and used the package from there. So far everything is working fine

koto commented 1 year ago

I can confirm that the PR fixes the issue on my application using hybrid (ng1+ng2). Without the PR, the cheatsheet doesn't open until several seconds passed (change detection is not triggered). With the PR, it's instantaneous.

Coffee-Tea commented 1 year ago

@ilueckel @koto Thanks for your inputs here. v15 is released https://www.npmjs.com/package/angular2-hotkeys?activeTab=versions Could u pls test it out form npm? Thanks!

Coffee-Tea commented 1 year ago

hey @ilueckel could u please let me know why @types/mousetrap moved to devDeps from deps in package.json here?

I would like to clarify that in the scope of https://github.com/brtnshrdr/angular2-hotkeys/issues/170

Cc @negibouze

ilueckel commented 1 year ago

Hi, that's my bad - I oversaw that MouseTrapInstance was exported in HotkeysService. I'll create a new pull request