search

bruceravel / demeter

Process and analyze X-ray Absorption Spectroscopy data using Feff and either Larch or Ifeffit.
http://bruceravel.github.io/demeter
Other
67 stars 32 forks source link

secure DOIs #30

Closed katrinleinweber closed 8 years ago

katrinleinweber commented 8 years ago

new suggested resolver, see https://www.doi.org/

bruceravel commented 8 years ago

Hi @katrinleinweber !

I am closing this without pulling. I agree with you 100% that I should use the https link. However, I found 51 examples of the string dx.doi in the demeter code base. It seems easier to reject this PR and simply fix them all with a normal commit.

So ... thank you:exclamation: And please do not think that my rejecting this PR means that I don't want to see more useful feedback & contributions from you in the future. You're awesome!

bruceravel commented 8 years ago

@katrinleinweber The trickiest part turned out to be getting all the DOIs right in the new documentation: see http://bruceravel.github.io/demeter/#docs

The new docs are generated using sphinx, which in turn uses pybtex. Pybtex resolves DOI biobliography entries to http URLs. I modified my own copy of the relevant file, but I am going to submit an issue at the pybtex bitbucket site about that.

Thanks again.