fixes to Larch.pm for Windows

bruceravel / demeter

Process and analyze X-ray Absorption Spectroscopy data using Feff and either Larch or Ifeffit.

http://bruceravel.github.io/demeter

Other

67 stars 32 forks source link

fixes to Larch.pm for Windows #48

Closed newville closed 6 years ago

newville commented 7 years ago

This now allows Larch to work as backend on Windows as well as unixy systems. It does test for larch_server without specifying the version of python, which works on all systems I've tested, and should also work on all Linuxes.

For Windows, Perl5.18 seems to not have a sufficient version of RPC::XML::Client, but using Strawberry Perl 5.24 did work.

newville commented 7 years ago

@bruceravel This will now find larch_server from PATH, from a single-file larch installer, or from larch an Anaconda environment. It does work (for me anyway) on Windows and Mac too.

newville commented 7 years ago

@bruceravel Well "works" in the sense that Athena finds and runs the correct larch_server. On Windows, I'm seeing an error on importing data... will investigate.

newville commented 7 years ago

@bruceravel I verified that I could get an error reading data on MacOSX as well, but also verified that

I can read at least 10 different files, with several different column layouts
Larch.pm does pass its self test, which does read a data file (the same datafile) and runs through the steps of basic processing and autobk, repeating 400 times.

So I think the Larch interface itself is fine, but there may be a problem using the Larch backend to read some files. Anyway, this is far ahead of the master branch and ready to merge.

bruceravel commented 7 years ago

Awesome. Very excited about this. I have a mountain of demeter chores for the shutdown, which starts next week.