search

bruceravel / demeter

Process and analyze X-ray Absorption Spectroscopy data using Feff and either Larch or Ifeffit.
http://bruceravel.github.io/demeter
Other
67 stars 32 forks source link

Must patch DemeterBuilder.pm to run on a Mac #60

Open joefowler opened 5 years ago

joefowler commented 5 years ago

Hi Bruce. I'm your friendly MacPorts maintainer. As you can see at their issue tracker 55973, I have had to apply a source patch to DemeterBuilder.pm from your release v0.9.26 in order for it to build on a Mac.

In essence, I deleted the do-nothing Mac OSX case from sub ACTION_compile_ifeffit_wrapper. While I was at it, I also deleted sub ACTION_test_for_larchserver, because it was throwing off my syntax highlighter. (I don't understand that.)

I don't understand why this is a new problem, because that file has been mostly unchanged for years, but so it goes. I'll attach the patch that seemed to work for me. I've submitted it as a MacPorts patch for use with 0.9.26, but perhaps you'd consider incorporating it (or something better) in your future releases? I'm sure you can do better, because I know almost zero Perl.

joefowler commented 5 years ago

Here's the patch for DemeterBuilder.pm:

patch-build-darwin-fix.diff