search

brummer10 / guitarix

guitarix virtual versatile amplification for Jack/Linux
287 stars 34 forks source link

jsonparser: fix null handling #187

Closed zainin closed 1 month ago

zainin commented 1 month ago

This is an attempt to fix #186 .

To be fair, I don't fully understand what the parsing of denormals is doing, but it looks to me like it's eating the first letter of "null" value.

In case of parsing online presets from https://musical-artifacts.com/artifacts.json?apps=guitarix that means it fails when it gets to "file_hash": null, which appears in a few entries. I think it tries to parse the value as ull and fails.

brummer10 commented 1 month ago

Hi Thanks for your pull request, this points me in the right direction to fix this issue. The issue is that we've now some "artifacts" at https://musical-artifacts.com/ which claim they are usable with guitarix, but in fact they are sfz files. This leads to a failure when we try to read the artifact descriptions. The json parser fail at this state only because the downloaded file isn't a json file. The right solution is to avoid download them at all by filter them out right on the download state by not only looking for use with app but as well for the artifact format. https://github.com/brummer10/guitarix/commit/8cd26c2101bae54525387ed69833bf1e28750ff4

Thanks again for your pull request, even if I can't merge it, it is very much appreciated.

regards hermann

zainin commented 1 month ago

Hi Hermann,

thanks for the explanation.

I'm new to guitarix and I was wondering how to use the sfz format without downloading them through guitarix directly, I guess that answers my question. :)